-
Notifications
You must be signed in to change notification settings - Fork 150
Support probe configuration overrides in Installation API #4610
Description
The operator's container override types (e.g., CalicoNodeDaemonSetContainer, GoldmaneDeploymentContainer) only support Resources today. Users should be able to configure readiness/liveness probe parameters through the same override mechanism.
Fields to support:
PeriodSecondsTimeoutSecondsFailureThresholdInitialDelaySeconds
Currently the operator's setProbeTimeouts in pkg/controller/utils/component.go defaults all readiness probes to 30s period and all liveness probes to 60s period. These are reasonable production defaults but can't be overridden without patching the operator code.
This came up during the uber image work where goldmane's 30s readiness probe period was the tail latency for kind cluster startup. We worked around it by setting PeriodSeconds: 10 explicitly in the goldmane render code, but users in resource-constrained or fast-startup environments should be able to tune this.
Relates to: #4608