From 32cc43847dcffed3d0646cec2c3d3b59d9877d1e Mon Sep 17 00:00:00 2001
From: scrhartley <scrhartley@github.com>
Date: Tue, 9 Sep 2025 20:50:13 +0100
Subject: [PATCH 1/4] IO simplification

---
 .../java/starfederation/datastar/utils/SignalReader.java   | 7 ++-----
 .../src/main/java/org/example/servlets/HtmlServlet.java    | 5 +----
 2 files changed, 3 insertions(+), 9 deletions(-)

diff --git a/core/src/main/java/starfederation/datastar/utils/SignalReader.java b/core/src/main/java/starfederation/datastar/utils/SignalReader.java
index e3fd186..e9d0af2 100644
--- a/core/src/main/java/starfederation/datastar/utils/SignalReader.java
+++ b/core/src/main/java/starfederation/datastar/utils/SignalReader.java
@@ -37,12 +37,9 @@ public static void readSignals(RequestAdapter requestAdapter, ConcurrentMap<Stri
             }
         } else {
             // Handle other methods by reading the request body
-            StringBuilder requestBody = new StringBuilder();
+            StringWriter requestBody = new StringWriter();
             try (BufferedReader reader = requestAdapter.getReader()) {
-                String line;
-                while ((line = reader.readLine()) != null) {
-                    requestBody.append(line);
-                }
+                reader.transferTo(requestBody);
             }
 
             data = requestBody.toString();
diff --git a/examples/hello-world/src/main/java/org/example/servlets/HtmlServlet.java b/examples/hello-world/src/main/java/org/example/servlets/HtmlServlet.java
index 5acd847..85693ef 100644
--- a/examples/hello-world/src/main/java/org/example/servlets/HtmlServlet.java
+++ b/examples/hello-world/src/main/java/org/example/servlets/HtmlServlet.java
@@ -23,10 +23,7 @@ protected void doGet(HttpServletRequest req, HttpServletResponse resp) throws IO
 
         try (BufferedReader reader = new BufferedReader(new InputStreamReader(inputStream));
              PrintWriter writer = resp.getWriter()) {
-            String line;
-            while ((line = reader.readLine()) != null) {
-                writer.println(line);
-            }
+            reader.transferTo(writer);
         }
     }
 }

From e75d3d20fb88b6c8bfbfc9439aa862ca4e0605c1 Mon Sep 17 00:00:00 2001
From: scrhartley <scrhartley@github.com>
Date: Thu, 18 Sep 2025 21:28:27 +0100
Subject: [PATCH 2/4] Avoid unnecessary wrapping with a reader

---
 .../src/main/java/org/example/servlets/HtmlServlet.java      | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/examples/hello-world/src/main/java/org/example/servlets/HtmlServlet.java b/examples/hello-world/src/main/java/org/example/servlets/HtmlServlet.java
index 85693ef..c16edf1 100644
--- a/examples/hello-world/src/main/java/org/example/servlets/HtmlServlet.java
+++ b/examples/hello-world/src/main/java/org/example/servlets/HtmlServlet.java
@@ -21,9 +21,8 @@ protected void doGet(HttpServletRequest req, HttpServletResponse resp) throws IO
 
         resp.setContentType("text/html;charset=UTF-8");
 
-        try (BufferedReader reader = new BufferedReader(new InputStreamReader(inputStream));
-             PrintWriter writer = resp.getWriter()) {
-            reader.transferTo(writer);
+        try (inputStream; OutputStream output = resp.getOutputStream()) {
+            inputStream.transferTo(output);
         }
     }
 }

From 04112ebbdb5c211639ca57500178e7c3a39c1689 Mon Sep 17 00:00:00 2001
From: scrhartley <scrhartley@github.com>
Date: Thu, 18 Sep 2025 21:32:05 +0100
Subject: [PATCH 3/4] Add missing import

---
 .../main/java/starfederation/datastar/utils/SignalReader.java    | 1 +
 1 file changed, 1 insertion(+)

diff --git a/core/src/main/java/starfederation/datastar/utils/SignalReader.java b/core/src/main/java/starfederation/datastar/utils/SignalReader.java
index e9d0af2..e6ec533 100644
--- a/core/src/main/java/starfederation/datastar/utils/SignalReader.java
+++ b/core/src/main/java/starfederation/datastar/utils/SignalReader.java
@@ -6,6 +6,7 @@
 
 import java.io.BufferedReader;
 import java.io.IOException;
+import java.io.StringWriter;
 import java.util.Map;
 import java.util.Objects;
 import java.util.concurrent.ConcurrentMap;

From 62cba08259d40262385c71f2213e669b2b33e9d5 Mon Sep 17 00:00:00 2001
From: scrhartley <scrhartley@github.com>
Date: Wed, 24 Sep 2025 15:52:09 +0100
Subject: [PATCH 4/4] IO refactoring

---
 .../starfederation/datastar/utils/SignalReader.java   | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/core/src/main/java/starfederation/datastar/utils/SignalReader.java b/core/src/main/java/starfederation/datastar/utils/SignalReader.java
index e6ec533..512dc60 100644
--- a/core/src/main/java/starfederation/datastar/utils/SignalReader.java
+++ b/core/src/main/java/starfederation/datastar/utils/SignalReader.java
@@ -4,9 +4,10 @@
 import com.fasterxml.jackson.databind.ObjectMapper;
 import starfederation.datastar.adapters.request.RequestAdapter;
 
-import java.io.BufferedReader;
 import java.io.IOException;
+import java.io.Reader;
 import java.io.StringWriter;
+import java.io.Writer;
 import java.util.Map;
 import java.util.Objects;
 import java.util.concurrent.ConcurrentMap;
@@ -38,12 +39,10 @@ public static void readSignals(RequestAdapter requestAdapter, ConcurrentMap<Stri
             }
         } else {
             // Handle other methods by reading the request body
-            StringWriter requestBody = new StringWriter();
-            try (BufferedReader reader = requestAdapter.getReader()) {
-                reader.transferTo(requestBody);
+            try (Reader reader = requestAdapter.getReader(); Writer writer = new StringWriter()) {
+                reader.transferTo(writer);
+                data = writer.toString();
             }
-
-            data = requestBody.toString();
             if (data.isEmpty()) {
                 throw new IllegalArgumentException("Request body cannot be empty.");
             }