Skip to content

Commit d3c6336

Browse files
Parse does not recognize Pwd as a valid password field alias (#263)
* Initial plan for issue * Add 'pwd' as an alias for 'password' in connection strings Co-authored-by: shueybubbles <2224906+shueybubbles@users.noreply.github.com> * Address PR feedback: fix CHANGELOG version and add test for pwd alias Co-authored-by: shueybubbles <2224906+shueybubbles@users.noreply.github.com> * update version and fix tests * match test to the request --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: shueybubbles <2224906+shueybubbles@users.noreply.github.com> Co-authored-by: davidshi <david.shiflet@microsoft.com>
1 parent 661c0e6 commit d3c6336

File tree

4 files changed

+10
-1
lines changed

4 files changed

+10
-1
lines changed

CHANGELOG.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,11 @@
11
# Changelog
2+
## 1.8.2
3+
4+
### Bug fixes
5+
6+
* Added "Pwd" as a recognized alias for "Password" in connection strings (#262)
7+
* Updated `isProc` to detect more keywords
8+
29
## 1.7.0
310

411
### Changed

msdsn/conn_str.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -628,6 +628,7 @@ var adoSynonyms = map[string]string{
628628
"addr": Server,
629629
"user": UserID,
630630
"uid": UserID,
631+
"pwd": Password,
631632
"initial catalog": Database,
632633
"column encryption setting": "columnencryption",
633634
}

msdsn/conn_str_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,7 @@ func TestValidConnectionString(t *testing.T) {
107107
{"", func(p Config) bool { return p.DisableRetry == disableRetryDefault }},
108108
{"MultiSubnetFailover=true;NoTraceID=true", func(p Config) bool { return p.MultiSubnetFailover && p.NoTraceID }},
109109
{"MultiSubnetFailover=false", func(p Config) bool { return !p.MultiSubnetFailover }},
110+
{"Pwd=placeholder", func(p Config) bool { return p.Password == "placeholder" }},
110111
// those are supported currently, but maybe should not be
111112
{"someparam", func(p Config) bool { return true }},
112113
{";;=;", func(p Config) bool { return true }},

version.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import "fmt"
44

55
// Update this variable with the release tag before pushing the tag
66
// This value is written to the prelogin and login7 packets during a new connection
7-
const driverVersion = "v1.8.0"
7+
const driverVersion = "v1.8.2"
88

99
func getDriverVersion(ver string) uint32 {
1010
var majorVersion uint32

0 commit comments

Comments
 (0)