fix: Restore tab support, fix service trait signatures, and remove resolve.sh

[Copilot]

Several regressions and issues accumulated across prior commits that drifted from main: tab indentation support was dropped, service trait return types were hardcoded to String, batch_analyze discarded its results, and a resolve.sh script that mutated source files via sed was committed.

Indentation (ast-engine)

• Restored indent.rs and template.rs to main-branch state (58e59d6) — re-adds get_tab, get_indent_at_offset_with_tab, and the is_tab: bool parameter to indent_lines for correct tab-indented replacement behavior

Service traits (thread-services)

• analyzer.rs: find_pattern, find_all_patterns, and find_nodes_by_kind now correctly return ServiceResult<Vec<CodeMatch<'_, D>>> (not hardcoded String); batch_analyze returns Ok(results) instead of Ok(vec![])
• parser.rs: postprocess_document restored to ServiceResult<ParsedDocument<D>> returning Ok(document); SupportLang import fixed to thread_language::SupportLang (self-referential thread_services::types::SupportLang path doesn't resolve)
• lib.rs: Bare // comment inside a //! doc block changed to //!

Rule engine

• test_rewrite test restored in trans.rs inside the existing mod test block with the correct Trans<String> type

Language trait

• Language::from_path default restored to unimplemented!() (matching main); removes ambiguous TODO about whether to panic

Misc

• _typos.toml: re-adds inout to extend-ignore-identifiers-re — identifier appears in classifications/_universal_rules.json
• resolve.sh: removed — script was patching source files via sed and should never have been committed

---

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

[Copilot]

Pull request overview

This PR restores several behaviors that had regressed from main, spanning indentation handling in ast-engine, correct generic return types in thread-services traits, and cleanup of an unsafe repo script.

Changes:

• Restores tab-aware indentation detection and re-indentation behavior in the AST replacer/template pipeline.
• Fixes thread-services trait signatures to return generic CodeMatch<'_, D> results and ensures batch_analyze returns accumulated results.
• Removes the committed resolve.sh that edited source files via sed, and restores a rule-engine rewrite test + small config/doc tweaks.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
resolve.sh	Removes an unsafe script that mutates tracked source files.
crates/services/src/traits/parser.rs	Fixes SupportLang import under feature flags and restores postprocess_document to return the parsed document via ServiceResult.
crates/services/src/traits/analyzer.rs	Restores generic CodeMatch<'_, D> return types and fixes batch_analyze to return collected results.
crates/services/src/lib.rs	Fixes a doc-comment formatting issue inside a //! block.
crates/rule-engine/src/transform/trans.rs	Restores test_rewrite in the existing test module.
crates/ast-engine/src/replacer/template.rs	Threads tab-awareness through template variable indentation and replacement generation.
crates/ast-engine/src/replacer/indent.rs	Re-adds tab handling (get_tab, get_indent_at_offset_with_tab) and updates indentation logic + tests.
crates/ast-engine/src/language.rs	Restores Language::from_path default to unimplemented!() with a clearer panic message.
_typos.toml	Adds inout to ignored identifiers regex list.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The docstring says this default implementation returns None when the file type is not supported, but the default body now panics via unimplemented!(). Please update the documentation to reflect that the default panics unless overridden (or restore a non-panicking default if the docstring is intended to be accurate).

[github-actions]

👋 Hey @Copilot,

Thanks for your contribution to thread! 🧵

You need to agree to the CLA first... 🖊️

Before we can accept your contribution, you need to agree to our Contributor License Agreement (CLA).

To agree to the CLA, please comment:

I read the contributors license agreement and I agree to it.

Those exact words are important¹, so please don't change them. 😉

You can read the full CLA here: Contributor License Agreement

---

✅ @Copilot has signed the CLA.

---

_{You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.}

Footnotes

1. Our bot needs those exact words to recognize that you agree to the CLA. ↩