From 6ec2af3cef646523f9e106c91abe1fb12fb76403 Mon Sep 17 00:00:00 2001 From: Douglas Thor Date: Sun, 15 Feb 2026 23:36:44 -0800 Subject: [PATCH] Update remove_invalid_(binary|library) gazelle tests. These changes will make a little more sense in a followup PR that finishes the "delete invalid targets" work started in #3046. In that PR, I pushed back on changes that resulted in py_test and py_library targets getting removed if they were invalid (see https://github.com/bazel-contrib/rules_python/pull/3046#pullrequestreview-3014780071 and https://github.com/bazel-contrib/rules_python/pull/3046#issuecomment-3094797158). This PR updates tests by adding some always-valid targets and does some light renaming of the targets. --- gazelle/python/testdata/remove_invalid_binary/BUILD.in | 6 ++++-- gazelle/python/testdata/remove_invalid_binary/BUILD.out | 5 +++-- gazelle/python/testdata/remove_invalid_binary/__init__.py | 0 gazelle/python/testdata/remove_invalid_library/BUILD.in | 7 ++++++- gazelle/python/testdata/remove_invalid_library/BUILD.out | 7 ++++++- gazelle/python/testdata/remove_invalid_library/my_test.py | 0 6 files changed, 19 insertions(+), 6 deletions(-) create mode 100644 gazelle/python/testdata/remove_invalid_binary/__init__.py create mode 100644 gazelle/python/testdata/remove_invalid_library/my_test.py diff --git a/gazelle/python/testdata/remove_invalid_binary/BUILD.in b/gazelle/python/testdata/remove_invalid_binary/BUILD.in index 87d357139b..f4bfd65c1b 100644 --- a/gazelle/python/testdata/remove_invalid_binary/BUILD.in +++ b/gazelle/python/testdata/remove_invalid_binary/BUILD.in @@ -1,11 +1,13 @@ load("@rules_python//python:defs.bzl", "py_binary", "py_library") py_library( - name = "keep_library", + name = "remove_invalid_binary", + srcs = ["__init__.py"], deps = ["//keep_binary:foo"], ) + py_binary( - name = "remove_invalid_binary", + name = "remove_invalid_binary_bin", srcs = ["__main__.py"], data = ["testdata/test.txt"], visibility = ["//:__subpackages__"], diff --git a/gazelle/python/testdata/remove_invalid_binary/BUILD.out b/gazelle/python/testdata/remove_invalid_binary/BUILD.out index 069188f5ca..a217b4bdaf 100644 --- a/gazelle/python/testdata/remove_invalid_binary/BUILD.out +++ b/gazelle/python/testdata/remove_invalid_binary/BUILD.out @@ -1,6 +1,7 @@ load("@rules_python//python:defs.bzl", "py_library") py_library( - name = "keep_library", - deps = ["//keep_binary:foo"], + name = "remove_invalid_binary", + srcs = ["__init__.py"], + visibility = ["//:__subpackages__"], ) diff --git a/gazelle/python/testdata/remove_invalid_binary/__init__.py b/gazelle/python/testdata/remove_invalid_binary/__init__.py new file mode 100644 index 0000000000..e69de29bb2 diff --git a/gazelle/python/testdata/remove_invalid_library/BUILD.in b/gazelle/python/testdata/remove_invalid_library/BUILD.in index 3f24c8df35..815e673ee1 100644 --- a/gazelle/python/testdata/remove_invalid_library/BUILD.in +++ b/gazelle/python/testdata/remove_invalid_library/BUILD.in @@ -1,4 +1,4 @@ -load("@rules_python//python:defs.bzl", "py_library") +load("@rules_python//python:defs.bzl", "py_library", "py_test") py_library( name = "remove_invalid_library", @@ -14,3 +14,8 @@ py_library( "@pypi//foo", ], ) + +py_test( + name = "my_test", + srcs = ["my_test.py"], +) diff --git a/gazelle/python/testdata/remove_invalid_library/BUILD.out b/gazelle/python/testdata/remove_invalid_library/BUILD.out index 4a6fffa183..80d47076c3 100644 --- a/gazelle/python/testdata/remove_invalid_library/BUILD.out +++ b/gazelle/python/testdata/remove_invalid_library/BUILD.out @@ -1,4 +1,4 @@ -load("@rules_python//python:defs.bzl", "py_library") +load("@rules_python//python:defs.bzl", "py_library", "py_test") py_library( name = "deps_with_no_srcs_library", @@ -8,3 +8,8 @@ py_library( "@pypi//foo", ], ) + +py_test( + name = "my_test", + srcs = ["my_test.py"], +) diff --git a/gazelle/python/testdata/remove_invalid_library/my_test.py b/gazelle/python/testdata/remove_invalid_library/my_test.py new file mode 100644 index 0000000000..e69de29bb2