From dde00fdc1e6aca0c2a075a3910300923a128b428 Mon Sep 17 00:00:00 2001 From: KJ Date: Tue, 31 Mar 2026 11:43:15 +0900 Subject: [PATCH 1/2] the approved workflow here does nothing --- .github/workflows/merge-bump.yml | 6 ------ 1 file changed, 6 deletions(-) diff --git a/.github/workflows/merge-bump.yml b/.github/workflows/merge-bump.yml index 301c1a5e..2e615c22 100644 --- a/.github/workflows/merge-bump.yml +++ b/.github/workflows/merge-bump.yml @@ -7,14 +7,8 @@ on: - bump/rc/* jobs: - approved: - runs-on: ubuntu-latest - steps: - - run: echo "Approved!" - merge-bump: runs-on: ubuntu-latest - needs: [approved] steps: - id: generate-token uses: tibdex/github-app-token@v2 From 6535835fdf597ed013edab93413f131ee460b2e8 Mon Sep 17 00:00:00 2001 From: KJ Date: Tue, 31 Mar 2026 11:45:21 +0900 Subject: [PATCH 2/2] replace this workflow in favor of branch protection rule instead --- .github/workflows/pull-requests.yml | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/.github/workflows/pull-requests.yml b/.github/workflows/pull-requests.yml index a054c69e..2696d04a 100644 --- a/.github/workflows/pull-requests.yml +++ b/.github/workflows/pull-requests.yml @@ -34,16 +34,3 @@ jobs: github-actions-tests: needs: [upload] uses: ./.github/workflows/github-actions-tests.yml - - approved: - needs: [integration-tests, e2e-tests, github-actions-tests] - if: ${{ always() }} - runs-on: ubuntu-latest - steps: - - run: | - if [[ "${{ needs.integration-tests.result }}" == "success" && "${{ needs.e2e-tests.result }}" == "success" ]]; then - echo "Approved!" - else - echo "Not approved!" - exit 1 - fi