From f987dce8847d35ec4c6045dc68f0cc7273b3b5fc Mon Sep 17 00:00:00 2001 From: PeterYinusa Date: Tue, 24 Mar 2026 19:48:48 +0000 Subject: [PATCH 1/2] docs: remove stale nameOrHandle param from switchToWindow JSDoc --- src/wallet/pages/add-network.ts | 1 - src/wallet/pages/approve-all.ts | 1 - src/wallet/pages/approve.ts | 1 - src/wallet/pages/confirm-transaction.ts | 1 - src/wallet/pages/connect.ts | 1 - src/wallet/pages/send.ts | 1 - src/wallet/pages/sign-in-request.ts | 1 - src/wallet/pages/sign-message.ts | 1 - src/wallet/pages/signature-request.ts | 1 - 9 files changed, 9 deletions(-) diff --git a/src/wallet/pages/add-network.ts b/src/wallet/pages/add-network.ts index 4e1dd3e..26b79ec 100644 --- a/src/wallet/pages/add-network.ts +++ b/src/wallet/pages/add-network.ts @@ -58,7 +58,6 @@ export class AddNetwork implements IConfirmation { * * * @template TPage - * @param {*} nameOrHandle * @param {new () => TPage} page * @return {*} {Promise} * @memberof AddNetwork diff --git a/src/wallet/pages/approve-all.ts b/src/wallet/pages/approve-all.ts index d29d1cf..4b1bd51 100644 --- a/src/wallet/pages/approve-all.ts +++ b/src/wallet/pages/approve-all.ts @@ -57,7 +57,6 @@ export class ApproveAll implements IConfirmation { * * * @template TPage - * @param {*} nameOrHandle * @param {new () => TPage} page * @return {*} {Promise} * @memberof ApproveAll diff --git a/src/wallet/pages/approve.ts b/src/wallet/pages/approve.ts index f893c99..962c7f2 100644 --- a/src/wallet/pages/approve.ts +++ b/src/wallet/pages/approve.ts @@ -51,7 +51,6 @@ export class Approve implements IConfirmation { * * * @template TPage - * @param {*} nameOrHandle * @param {new () => TPage} page * @return {*} {Promise} * @memberof Approve diff --git a/src/wallet/pages/confirm-transaction.ts b/src/wallet/pages/confirm-transaction.ts index dbb3f40..6e366a0 100644 --- a/src/wallet/pages/confirm-transaction.ts +++ b/src/wallet/pages/confirm-transaction.ts @@ -58,7 +58,6 @@ export class ConfirmTransaction implements IConfirmation { * * * @template TPage - * @param {*} nameOrHandle * @param {new () => TPage} page * @return {*} {Promise} * @memberof ConfirmTransaction diff --git a/src/wallet/pages/connect.ts b/src/wallet/pages/connect.ts index e776fe8..0776101 100644 --- a/src/wallet/pages/connect.ts +++ b/src/wallet/pages/connect.ts @@ -58,7 +58,6 @@ export class Connect implements IConfirmation { * * * @template TPage - * @param {*} nameOrHandle * @param {new () => TPage} page * @return {*} {Promise} * @memberof Connect diff --git a/src/wallet/pages/send.ts b/src/wallet/pages/send.ts index 9b793f9..aeb955e 100644 --- a/src/wallet/pages/send.ts +++ b/src/wallet/pages/send.ts @@ -58,7 +58,6 @@ export class Send implements IConfirmation { * * * @template TPage - * @param {*} nameOrHandle * @param {new () => TPage} page * @return {*} {Promise} * @memberof Send diff --git a/src/wallet/pages/sign-in-request.ts b/src/wallet/pages/sign-in-request.ts index 0917b73..d7213c1 100644 --- a/src/wallet/pages/sign-in-request.ts +++ b/src/wallet/pages/sign-in-request.ts @@ -58,7 +58,6 @@ export class SignInRequest implements IConfirmation { * * * @template TPage - * @param {*} nameOrHandle * @param {new () => TPage} page * @return {*} {Promise} * @memberof SignInRequest diff --git a/src/wallet/pages/sign-message.ts b/src/wallet/pages/sign-message.ts index fd975c1..bc457da 100644 --- a/src/wallet/pages/sign-message.ts +++ b/src/wallet/pages/sign-message.ts @@ -58,7 +58,6 @@ export class SignMessage implements IConfirmation { * * * @template TPage - * @param {*} nameOrHandle * @param {new () => TPage} page * @return {*} {Promise} * @memberof SignMessage diff --git a/src/wallet/pages/signature-request.ts b/src/wallet/pages/signature-request.ts index 1bba022..1d4583d 100644 --- a/src/wallet/pages/signature-request.ts +++ b/src/wallet/pages/signature-request.ts @@ -57,7 +57,6 @@ export class SignatureRequest implements IConfirmation { * * * @template TPage - * @param {*} nameOrHandle * @param {new () => TPage} page * @return {*} {Promise} * @memberof SignatureRequest From af227c1888f9976a7c81b4ff0424fc13f209f1fb Mon Sep 17 00:00:00 2001 From: PeterYinusa Date: Tue, 24 Mar 2026 19:51:53 +0000 Subject: [PATCH 2/2] fix: replace Replace InstanceType with IConfirmation --- src/wallet/pages/add-network.ts | 2 +- src/wallet/pages/approve-all.ts | 2 +- src/wallet/pages/approve.ts | 2 +- src/wallet/pages/confirm-transaction.ts | 2 +- src/wallet/pages/connect.ts | 2 +- src/wallet/pages/send.ts | 2 +- src/wallet/pages/sign-in-request.ts | 2 +- src/wallet/pages/sign-message.ts | 2 +- src/wallet/pages/signature-request.ts | 2 +- 9 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/wallet/pages/add-network.ts b/src/wallet/pages/add-network.ts index 26b79ec..085cbb1 100644 --- a/src/wallet/pages/add-network.ts +++ b/src/wallet/pages/add-network.ts @@ -12,7 +12,7 @@ import { DappDriver } from '../../session/dapp-driver'; export class AddNetwork implements IConfirmation { public url: string | RegExp; public title: string; - private readonly addNetwork: InstanceType; + private readonly addNetwork: IConfirmation; constructor() { this.addNetwork = new DappDriver.Instance.Extension.pages.AddNetwork(); diff --git a/src/wallet/pages/approve-all.ts b/src/wallet/pages/approve-all.ts index 4b1bd51..5cdf605 100644 --- a/src/wallet/pages/approve-all.ts +++ b/src/wallet/pages/approve-all.ts @@ -12,7 +12,7 @@ import { DappDriver } from '../../session/dapp-driver'; export class ApproveAll implements IConfirmation { public url: string | RegExp; public title: string; - private readonly approveAll: InstanceType; + private readonly approveAll: IConfirmation; constructor() { this.approveAll = new DappDriver.Instance.Extension.pages.ApproveAll(); diff --git a/src/wallet/pages/approve.ts b/src/wallet/pages/approve.ts index 962c7f2..c8c55f6 100644 --- a/src/wallet/pages/approve.ts +++ b/src/wallet/pages/approve.ts @@ -5,7 +5,7 @@ import { DappDriver } from '../../session/dapp-driver'; export class Approve implements IConfirmation { public url: string | RegExp; public title: string; - private readonly approve: InstanceType; + private readonly approve: IConfirmation; constructor() { this.approve = new DappDriver.Instance.Extension.pages.Approve(); diff --git a/src/wallet/pages/confirm-transaction.ts b/src/wallet/pages/confirm-transaction.ts index 6e366a0..1c415a8 100644 --- a/src/wallet/pages/confirm-transaction.ts +++ b/src/wallet/pages/confirm-transaction.ts @@ -12,7 +12,7 @@ import { DappDriver } from '../../session/dapp-driver'; export class ConfirmTransaction implements IConfirmation { public url: string | RegExp; public title: string; - private readonly confirmTx: InstanceType; + private readonly confirmTx: IConfirmation; constructor() { this.confirmTx = new DappDriver.Instance.Extension.pages.ConfirmTransaction(); diff --git a/src/wallet/pages/connect.ts b/src/wallet/pages/connect.ts index 0776101..7865333 100644 --- a/src/wallet/pages/connect.ts +++ b/src/wallet/pages/connect.ts @@ -12,7 +12,7 @@ import { DappDriver } from '../../session/dapp-driver'; export class Connect implements IConfirmation { public url: string | RegExp; public title: string; - private readonly connect: InstanceType; + private readonly connect: IConfirmation; constructor() { this.connect = new DappDriver.Instance.Extension.pages.Connect(); diff --git a/src/wallet/pages/send.ts b/src/wallet/pages/send.ts index aeb955e..6e11cba 100644 --- a/src/wallet/pages/send.ts +++ b/src/wallet/pages/send.ts @@ -12,7 +12,7 @@ import { DappDriver } from '../../session/dapp-driver'; export class Send implements IConfirmation { public url: string | RegExp; public title: string; - private readonly send: InstanceType; + private readonly send: IConfirmation; constructor() { this.send = new DappDriver.Instance.Extension.pages.Send(); diff --git a/src/wallet/pages/sign-in-request.ts b/src/wallet/pages/sign-in-request.ts index d7213c1..84e0ef2 100644 --- a/src/wallet/pages/sign-in-request.ts +++ b/src/wallet/pages/sign-in-request.ts @@ -12,7 +12,7 @@ import { DappDriver } from '../../session/dapp-driver'; export class SignInRequest implements IConfirmation { public url: string | RegExp; public title: string; - private readonly signInRequest: InstanceType; + private readonly signInRequest: IConfirmation; constructor() { this.signInRequest = new DappDriver.Instance.Extension.pages.SignInRequest(); diff --git a/src/wallet/pages/sign-message.ts b/src/wallet/pages/sign-message.ts index bc457da..ddb6799 100644 --- a/src/wallet/pages/sign-message.ts +++ b/src/wallet/pages/sign-message.ts @@ -12,7 +12,7 @@ import { DappDriver } from '../../session/dapp-driver'; export class SignMessage implements IConfirmation { public url: string | RegExp; public title: string; - private readonly signMessage: InstanceType; + private readonly signMessage: IConfirmation; constructor() { this.signMessage = new DappDriver.Instance.Extension.pages.SignMessage(); diff --git a/src/wallet/pages/signature-request.ts b/src/wallet/pages/signature-request.ts index 1d4583d..b726895 100644 --- a/src/wallet/pages/signature-request.ts +++ b/src/wallet/pages/signature-request.ts @@ -12,7 +12,7 @@ import { DappDriver } from '../../session/dapp-driver'; export class SignatureRequest implements IConfirmation { public url: string | RegExp; public title: string; - private readonly signatureRequest: InstanceType; + private readonly signatureRequest: IConfirmation; constructor() { this.signatureRequest = new DappDriver.Instance.Extension.pages.SignatureRequest();