-
Notifications
You must be signed in to change notification settings - Fork 26
Open
Description
Problem
The agent's initial fix threw a click.BadParameter error for both CLI and config file exclusions. This meant that configuration file errors were reported as CLI parameter errors, creating a poor user experience. It took an external automated review to point out this UX issue.
Impact
- Suboptimal user experience (confusing error messages)
- Required external intervention to catch the issue
- Agent didn't proactively consider the context difference between CLI and config errors
Context
This issue was identified during the bugfix session for ambient-code/agentready#306 addressing ambient-code/agentready#302.
The agent should have recognized that:
- CLI errors →
click.BadParameter(appropriate) - Config file errors →
click.ClickException(better UX)
Recommended Solution
The bugfix workflow should:
- Include guidance in the
/fixphase about considering error message UX - Add a checklist item: "Ensure error messages clearly indicate the source of the problem"
- Prompt the agent to think about different error contexts (CLI vs. config vs. runtime)
- Consider adding a review step that specifically checks error handling paths
Could add a "User Experience Review" section that prompts the agent to:
- Test error paths manually
- Verify error messages are clear and actionable
- Ensure errors point users to the right place to fix issues
Reference
From PR comment: #42 (comment)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels