Skip to content

FloatingComposer doesn't use dictionary for UI elements #2530

@herr-samsa

Description

@herr-samsa

What’s broken?

When using the comments extension, I've noticed that even though the rest of BlockNote's editor UI is correctly translated to the currently active language, the save button of the FloatingComposer is not.

I think, it might be due to the way the button is implemented in react/src/components/Comments/FloatingComposer.tsx . As I understand it, instead of the literal string 'Save' the button element should have {dict.comments.save_button_text} as a child.

Image

What did you expect to happen?

The comments extension should respect the language settings, BlockNote editor has been initialized with, all the way, including active extensions. Since CommentsExtension already makes use of the dictionary, I don't see why the floating editor should be an exception. Long story short: I want to see the correct translation for "Save" on the save button :)

Steps to reproduce

No response

BlockNote version

No response

Environment

No response

Additional context

No response

Contribution

  • I'd be interested in contributing a fix for this issue

Sponsor

  • I'm a sponsor and would appreciate if you could look into this sooner than later 💖

Metadata

Metadata

Assignees

No one assigned

    Labels

    bug:P3Medium: Noticeable but non-blocking issues.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions