Skip to content

Commit 560b159

Browse files
author
DavidQ
committed
Finalize classes_old_keep decision
1 parent 24ddad7 commit 560b159

8 files changed

+127
-40
lines changed

‎docs/dev/CODEX_COMMANDS.md‎

Lines changed: 23 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,28 @@
11
MODEL: GPT-5.3-codex
2-
REASONING: medium
2+
REASONING: high
33

44
COMMAND:
5-
Execute BUILD_PR_TARGETED_REPO_CLEANUP_PASS_6_CLASSES_OLD_KEEP_REFERENCE_NORMALIZATION.
5+
Execute BUILD_PR_TARGETED_REPO_CLEANUP_PASS_7_FINAL_REVIEW_AND_DECISION
66

7-
- Normalize wording of classes_old_keep references across docs
8-
- Do not change meaning, only clarify as docs-only placeholder
9-
- Do not create/delete/move any files or folders
10-
- Generate:
11-
docs/dev/reports/classes_old_keep_normalization_report.md
12-
docs/dev/reports/BUILD_PR_TARGETED_REPO_CLEANUP_PASS_6_CLASSES_OLD_KEEP_REFERENCE_NORMALIZATION_report.md
13-
docs/dev/reports/validation_checklist.txt
7+
Input:
8+
- normalization complete
9+
- classes_old_keep = docs-only placeholder
1410

15-
Package to:
16-
<project folder>/tmp/BUILD_PR_TARGETED_REPO_CLEANUP_PASS_6_CLASSES_OLD_KEEP_REFERENCE_NORMALIZATION.zip
11+
Steps:
12+
1. Review all normalized references
13+
2. Decide:
14+
a) remove references OR
15+
b) keep placeholder
16+
3. Justify decision
17+
4. Create:
18+
docs/dev/reports/classes_old_keep_final_decision_report.md
19+
docs/dev/reports/classes_old_keep_cleanup_recommendation.md
20+
docs/dev/reports/validation_checklist.txt
21+
22+
Constraints:
23+
- no file deletion in this PR
24+
- no folder creation
25+
- no runtime changes
26+
27+
Output:
28+
<project folder>/tmp/BUILD_PR_TARGETED_REPO_CLEANUP_PASS_7_FINAL_REVIEW_AND_DECISION.zip

‎docs/dev/COMMIT_COMMENT.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Normalize classes_old_keep references to docs-only placeholder
1+
Finalize classes_old_keep decision

‎docs/dev/NEXT_COMMAND.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Next: BUILD_PR_TARGETED_REPO_CLEANUP_PASS_7_FINAL_REVIEW
1+
Next: APPLY_PR_TARGETED_REPO_CLEANUP_PASS_7_DECISION

‎docs/dev/reports/change_summary.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
classes_old_keep reference normalization
1+
final decision for classes_old_keep

‎docs/dev/reports/classes_old_keep_cleanup_recommendation.md‎

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
# classes_old_keep Cleanup Recommendation
2+
3+
Generated: 2026-04-12
4+
Recommendation type: follow-up execution guidance
5+
6+
## Recommended Path
7+
Keep placeholder now; plan optional removal later in a dedicated docs-only lane.
8+
9+
## Immediate Recommendation (Current PR)
10+
- Preserve normalized terminology:
11+
- `classes_old_keep (docs-only placeholder, no on-disk path)`
12+
- Do not remove references in this lane.
13+
14+
## Future Removal Readiness Criteria
15+
Run a dedicated retirement lane only when all are true:
16+
1. Roadmap, cleanup inventory, cleanup matrix, enforcement map, and normalization report can be updated together.
17+
2. PR/build specs referencing `classes_old_keep` can be updated in one synchronized docs pass.
18+
3. Command/report metadata references are either intentionally retained or updated with explicit rationale.
19+
4. Validation confirms:
20+
- no `classes_old_keep` directory on disk,
21+
- no runtime/code references,
22+
- no collateral changes to `templates/`, `docs/archive/`, or SpriteEditor archive surfaces.
23+
24+
## Recommended Future Lane Shape
25+
- docs-only
26+
- no runtime edits
27+
- no file/folder structural operations
28+
- include explicit before/after reference inventory and rollback notes
29+
30+
## Risk Note
31+
Removing references prematurely can erase audit context for legacy-cleanup decisions; retaining a clearly labeled placeholder is lower risk until final retirement scope is approved.

‎docs/dev/reports/classes_old_keep_final_decision_report.md‎

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
1+
# classes_old_keep Final Decision Report
2+
3+
Generated: 2026-04-12
4+
Lane: BUILD_PR_TARGETED_REPO_CLEANUP_PASS_7_FINAL_REVIEW_AND_DECISION
5+
6+
## Input State
7+
- normalization complete
8+
- `classes_old_keep` treated as docs-only placeholder
9+
10+
## Step 1) Final Review Summary
11+
Reviewed normalized references in active docs (`docs/`, excluding `docs/archive/`):
12+
- Canonical phrase matches:
13+
- `classes_old_keep (docs-only placeholder, no on-disk path)` -> 60 matches
14+
- Residual raw-token matches (intentional/literal contexts + metadata/spec references):
15+
- 71 matches
16+
- On-disk path check:
17+
- `Test-Path classes_old_keep` -> `False`
18+
- Runtime/code import check scope (`tools/src/games/samples/tests`):
19+
- no matches in this lane
20+
21+
## Step 2) Decision
22+
Decision: **(b) keep placeholder**
23+
24+
## Step 3) Justification
25+
1. `classes_old_keep` has no on-disk directory and no active runtime usage.
26+
2. References remain concentrated in governance/planning/report/spec surfaces, where the placeholder preserves traceability of prior cleanup decisions.
27+
3. Removing references now would create documentation churn without reducing runtime risk, and would require synchronized edits across roadmap + cleanup reports + PR specs.
28+
4. Current normalized wording already clarifies the target status as docs-only and non-runtime.
29+
30+
## Decision Outcome
31+
- Keep `classes_old_keep` as a docs-only placeholder in current governance surfaces.
32+
- Defer reference removal to a future dedicated docs-retirement lane after synchronized scope is approved.
33+
34+
## Constraints Check
35+
- no file deletion performed
36+
- no folder creation performed
37+
- no runtime changes performed

‎docs/dev/reports/validation_checklist.txt‎

Lines changed: 17 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -1,36 +1,27 @@
1-
BUILD_PR_TARGETED_REPO_CLEANUP_PASS_6_CLASSES_OLD_KEEP_REFERENCE_NORMALIZATION
1+
BUILD_PR_TARGETED_REPO_CLEANUP_PASS_7_FINAL_REVIEW_AND_DECISION
22
Validation Checklist
33
Generated: 2026-04-12
44

5-
[PASS] wording normalized to docs-only placeholder terminology
6-
Evidence: canonical phrase applied across active docs; see `classes_old_keep_normalization_report.md`
5+
[PASS] final review of normalized references completed
6+
Evidence: canonical phrase scan + residual reference scan captured in final decision report
77

8-
[PASS] meaning preserved (no policy behavior change)
9-
Evidence: only terminology clarifications, no action/rule semantics changed
8+
[PASS] decision recorded (remove vs keep)
9+
Evidence: decision = keep placeholder in `classes_old_keep_final_decision_report.md`
1010

11-
[PASS] no file/folder move/rename/delete operations
12-
Evidence: `MOVE_DELETE_RENAME_CHECK: PASS`
13-
14-
[PASS] no `classes_old_keep/` directory created
15-
Evidence: `Test-Path classes_old_keep` remains False
16-
17-
[PASS] `templates/` untouched
18-
Evidence: `git diff --name-status -- templates` -> no entries
19-
20-
[PASS] `docs/archive/` untouched
21-
Evidence: `git diff --name-status -- docs/archive` -> no entries
22-
23-
[PASS] SpriteEditor archive surfaces untouched
24-
Evidence: `git diff --name-status -- docs/archive/tools/SpriteEditor_old_keep` -> no entries
25-
26-
[PASS] runtime code untouched
27-
Evidence: `git diff --name-only -- tools src games samples tests` -> no entries
11+
[PASS] decision justified
12+
Evidence: explicit multi-point rationale included in final decision report
2813

2914
[PASS] required reports generated
3015
Evidence:
31-
- `docs/dev/reports/classes_old_keep_normalization_report.md`
32-
- `docs/dev/reports/BUILD_PR_TARGETED_REPO_CLEANUP_PASS_6_CLASSES_OLD_KEEP_REFERENCE_NORMALIZATION_report.md`
16+
- `docs/dev/reports/classes_old_keep_final_decision_report.md`
17+
- `docs/dev/reports/classes_old_keep_cleanup_recommendation.md`
3318
- `docs/dev/reports/validation_checklist.txt`
3419

35-
[PASS] protected start_of_day directories untouched
36-
Evidence: `git status --short -- docs/dev/start_of_day/chatGPT docs/dev/start_of_day/codex` -> no entries
20+
[PASS] no file deletion in this PR
21+
Evidence: no D/R/C entries in current diff status filter
22+
23+
[PASS] no folder creation in this PR scope
24+
Evidence: no new directories required for deliverables; reports written in existing `docs/dev/reports/`
25+
26+
[PASS] no runtime changes
27+
Evidence: `git diff --name-only -- tools src games samples tests` -> no entries

‎docs/pr/BUILD_PR_TARGETED_REPO_CLEANUP_PASS_7_FINAL_REVIEW_AND_DECISION.md‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
# BUILD_PR_TARGETED_REPO_CLEANUP_PASS_7_FINAL_REVIEW_AND_DECISION
2+
3+
## Purpose
4+
Finalize decision for classes_old_keep after normalization.
5+
6+
## Options
7+
- remove all references
8+
- keep as documented placeholder
9+
10+
## Scope
11+
Docs-only decision. No structural changes unless explicitly approved in future PR.
12+
13+
## Deliverables
14+
- final_decision_report.md
15+
- cleanup_recommendation.md
16+
- validation_checklist.txt

0 commit comments

Comments
 (0)