Skip to content

Commit 26646ba

Browse files
author
DavidQ
committed
docs: add BUILD_PR bundle for conservative tools/shared extraction phase 1
1 parent 150fe5a commit 26646ba

18 files changed

+345
-373
lines changed

docs/dev/CODEX_COMMANDS.md

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -2,29 +2,29 @@ MODEL: GPT-5.4
22
REASONING: high
33

44
COMMAND:
5-
Create BUILD_PR_TOOLS_THEME_REUSE_BASELINE as a docs-to-code follow-up to PLAN_PR_TOOLS_SHARED_NORMALIZATION.
5+
Create BUILD_PR_TOOLS_SHARED_EXTRACTION_PHASE_1 as a conservative exact-cluster implementation.
66

77
Scope:
8-
- prioritize reuse of existing engine theme/UI assets before adding or expanding any new tool-local CSS
9-
- target active tools only:
10-
- tools/Asset Browser
11-
- tools/Palette Browser
12-
- tools/Parallax Scene Studio
13-
- tools/Sprite Editor
14-
- tools/Tilemap Studio
15-
- tools/Vector Asset Studio
16-
- tools/Vector Map Editor
8+
- active tools only
9+
- reuse existing tools/shared modules first
10+
- target only:
11+
- project system helper normalization
12+
- runtime asset loader helper normalization
13+
- runtime asset validation helper normalization
14+
- safe vector helper normalization already represented in tools/shared/vector/*
15+
- no style/theme work in this PR
16+
- no editor-state extraction
17+
- no render-pipeline rewrites
18+
- no tool-host work
1719
- preserve tools/SpriteEditor_old_keep
18-
- keep scope tight to shell/theme/layout normalization and import alignment only
19-
- do not refactor tool-specific behavior
20-
- do not rewrite roadmap wording
21-
- do not touch start_of_day directories
20+
- keep changed-file count minimal
21+
- stop and report if helper semantics diverge too much
2222

2323
Validation:
24-
- each touched tool loads
25-
- no console regressions
26-
- no shell/theme visual collapse
24+
- npm run test:launch-smoke -- --tools
2725
- report exact files changed
26+
- report extracted vs normalized helpers
27+
- report helpers intentionally left local and why
2828

2929
Output:
3030
- package repo-structured delta ZIP under <project folder>/tmp/

docs/dev/COMMIT_COMMENT.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
docs: add PLAN_PR for tools/shared normalization with engine-theme-first reuse priority
1+
docs: add BUILD_PR bundle for conservative tools/shared extraction phase 1
Lines changed: 55 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,55 @@
1+
# BUILD_PR_TOOLS_SHARED_EXTRACTION_PHASE_1 - Changes Report
2+
3+
Date: 2026-04-11
4+
5+
## Exact Files Changed
6+
- docs/pr/BUILD_PR_TOOLS_SHARED_EXTRACTION_PHASE_1.md
7+
- tools/shared/projectManifestContract.js
8+
- tools/shared/runtimeAssetLoader.js
9+
- tools/shared/runtimeAssetValidationUtils.js
10+
- tools/shared/runtimeStreaming.js
11+
- tools/shared/runtimeAssetSharedUtils.js
12+
- tools/shared/vector/vectorAssetBridge.js
13+
- tools/shared/vector/vectorAssetContract.js
14+
- tools/shared/vector/vectorRenderPrep.js
15+
- tools/shared/vector/vectorSafeValueUtils.js
16+
17+
## Extracted vs Normalized Helpers
18+
19+
Extracted (new shared helpers):
20+
- `tools/shared/runtimeAssetSharedUtils.js`
21+
- `sanitizeRuntimeText(value, fallback)`
22+
- `createRuntimeReport(level, code, message)`
23+
- `tools/shared/vector/vectorSafeValueUtils.js`
24+
- `sanitizeVectorText(value, fallback)`
25+
26+
Normalized (existing files now reuse extracted helpers):
27+
- `tools/shared/runtimeAssetLoader.js`
28+
- replaced local report/text helpers with `runtimeAssetSharedUtils`
29+
- `tools/shared/runtimeStreaming.js`
30+
- replaced local report/text helpers with `runtimeAssetSharedUtils`
31+
- `tools/shared/runtimeAssetValidationUtils.js`
32+
- normalized runtime text sanitization via `runtimeAssetSharedUtils`
33+
- `tools/shared/projectManifestContract.js`
34+
- normalized string sanitization to existing `safeString` from `projectSystemValueUtils`
35+
- `tools/shared/vector/vectorAssetBridge.js`
36+
- normalized local string sanitization to `sanitizeVectorText`
37+
- `tools/shared/vector/vectorAssetContract.js`
38+
- normalized local string sanitization to `sanitizeVectorText`
39+
- `tools/shared/vector/vectorRenderPrep.js`
40+
- normalized local string sanitization to `sanitizeVectorText`
41+
42+
## Helpers Intentionally Left Local
43+
- `sanitizeText/createReport` in:
44+
- `tools/shared/hotReloadSystem.js`
45+
- `tools/shared/platformValidationSuite.js`
46+
- `tools/shared/vectorAssetSystem.js`
47+
48+
Why left local:
49+
- These modules are orchestration/reporting surfaces with domain-specific report vocabulary and aggregation behavior.
50+
- Pulling them into this lane would expand beyond the requested exact-cluster (runtime loader/validation + vector-safe helper normalization) and increase risk/scope.
51+
52+
- Local helper clusters in tool app files (for example, sample-path/readout helpers in Parallax/Tilemap/Vector Asset Studio) were intentionally left unchanged.
53+
54+
Why left local:
55+
- Out of requested scope for this PR (would trend into editor-state extraction or broader refactor lanes).
Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
# BUILD_PR_TOOLS_SHARED_EXTRACTION_PHASE_1 - Validation Report
2+
3+
Date: 2026-04-11
4+
Branch: main
5+
6+
## Command Validation
7+
Executed:
8+
- `npm run test:launch-smoke -- --tools`
9+
10+
Result:
11+
- PASS Asset Browser
12+
- PASS Palette Browser
13+
- PASS Parallax Scene Studio
14+
- PASS Sprite Editor
15+
- PASS SpriteEditor_old_keep
16+
- PASS Tilemap Studio
17+
- PASS Vector Asset Studio
18+
- PASS Vector Map Editor
19+
- Summary: PASS=8 FAIL=0 TOTAL=8
20+
21+
Generated by test command:
22+
- `docs/dev/reports/launch_smoke_report.md`
23+
24+
## Scope Safety Checks
25+
- `tools/SpriteEditor_old_keep` modified: NO
26+
- start_of_day directories modified: NO
27+
- style/theme files touched in this BUILD lane: NO
28+
29+
## Semantic Divergence Gate
30+
- Runtime helper normalization limited to exact duplicate semantics (`sanitize text` + `create report` helper shape).
31+
- Project system normalization limited to aliasing existing `safeString` helper.
32+
- Vector helper normalization limited to existing string sanitization helper replacement in `tools/shared/vector/*`.
33+
- No behavior rewrites in editor state, render pipelines, or tool host.
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
VALIDATION CHECKLIST — BUILD_PR_TOOLS_SHARED_EXTRACTION_PHASE_1
2+
3+
Required:
4+
- [ ] touched tools still load
5+
- [ ] no new console errors
6+
- [ ] npm run test:launch-smoke -- --tools executed
7+
- [ ] no shell/theme regressions introduced by this PR
8+
- [ ] changed-file count stayed minimal
9+
- [ ] SpriteEditor_old_keep untouched
10+
- [ ] report exact extracted/normalized helpers
11+
- [ ] report helpers intentionally left local
12+
13+
Nice to have:
14+
- [ ] note any helper families that clearly belong in phase 2

0 commit comments

Comments
 (0)