Fix built in updater - Broke some time in 1.29.x?

[TheBestAstroNOT]

• Fix built in updater - Broke some time in 1.29.x? - [1.29.4 -> 1.30.1] upgrade path fails

Originally posted by @dreamsyntax in #494

Can you elaborate on what exactly is broken? I tested the updater in 1.29.6 and it worked just fine, I tried using 1.29.4 too but I got rate limited.

[dreamsyntax]

@TheBestAstroNOT when you get rate limited what happens? Maybe thats whats happening?
I tried 3 times, still failed, then launched with terminal instead of .desktop and it worked the 4th time.
No other changes.

Success case (directly running .desktop command in terminal for extra logs).
I don't know if that caused it to work, before was running the .desktop directly.

success.mp4

--
When it wasn't working, the progress bar would fill just like in the above video, but after it completes and R-II closes, it would never modify any files in the Reloaded dir nor relaunch.
Relaunching would show the same version

[Sewer56]

I've seen cases where update would fail under Wine, though I don't quite know the cause, unfortunately.

Been a thing for a very long time.

[TheBestAstroNOT]

@TheBestAstroNOT when you get rate limited what happens? Maybe thats whats happening? I tried 3 times, still failed, then launched with terminal instead of .desktop and it worked the 4th time. No other changes.

Success case (directly running .desktop command in terminal for extra logs). I don't know if that caused it to work, before was running the .desktop directly.

success.mp4
-- When it wasn't working, the progress bar would fill just like in the above video, but after it completes and R-II closes, it would never modify any files in the Reloaded dir nor relaunch. Relaunching would show the same version

You don't even get an update notification when you are rate-limited

[dreamsyntax]

Adding for historical purpose.
It is caused by launching from .desktop vs running directly in terminal, I can reproduce it every time on:
Linux Mint 22.3 / with Cinamon 6.6.6
Tested with Persona 4 Golden

[dreamsyntax]

Seems to happen even if launching .exe directly rather than .desktop.

I think its coincidence / race condition.

raw-exe.mp4

I cannot reproduce this on my main PC, but sometimes after the update completes it does not re-launch R-II automatically. Sometimes it does, sometimes it doesn't. But in that case it still writes the new/updated files.

This is probably not a new issue as Sewer said, and has been a long standing issue.

[TheBestAstroNOT]

Unable to reproduce on CachyOS (intel i5 11th gen, nvidia geforce mx450)

[dreamsyntax]

It wouldn't surprise me if its a thing only on very slow CPU, I'll see if I can add a wait on the file replace step or something as a test.

Wont get to it soon, but eventually.

[dreamsyntax]

Updated title:

• Built in Updater Breaks if Using Flatpak Protontricks

Details:

• Launching Reloaded-II via .desktop or Reloaded-II.exe directly via Desktop Environment launch context will cause the updater to not finish updating successfully, and not re-open itself
• Launching via a terminal context, even with flatpak Protontricks, will successfully update
• Only affects Protontricks installed with flatpak. assumes bashrc alias from tutorial, and 'host/all files' access given via flatseal
• Native protontricks does not have this issue

[Sewer56]

I'm guessing the workaround is to detect flatpak installed protontricks from the installer and do flatpak run in the Exec field of the desktop file.

Possible, but a bit painful, when you run Linux commands from Wine, you can't wait for them to exit, etc. so you can't really run commands to query stuff very well.