Conversation
Contributor
davidbakker123
left a comment
davidbakker123
left a comment
There was a problem hiding this comment.
Two final things,
- The ticket says the circuit should have an empty mapping. I guess that is the same as the identity mapping?
- You might want to consider using this feature to update the tests where this was an "issue" (like mentioned in the ticket). Maybe it is too much work and you can make a new ticket for it. :)
added 2 commits
March 9, 2026 15:21
…tly in the map() method
rares1609
deleted the
CQT-429-Add-mapping-attribute-to-circuit-object-in-opensquirrel
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.