More trait mappings and logging of unmapped I:R traits (#2906) #minor

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: IhateTrains <29546927+IhateTrains@users.noreply.github.com>

Author: 3 people

ImperatorToCK3.UnitTests/Mappers/Trait/TraitMapperTests.cs

@@ -122,4 +122,24 @@ public void UndefinedCK3TraitsAreNotSkipped() {
 		var ck3Traits = mapper.GetCK3TraitsForImperatorTraits(new[] { "impTrait" });
 		ck3Traits.Should().Contain("undefined");
 	}
+
+	[Fact]
+	public void UnmappedImperatorTraitsAreLoggedUnlessExplicitlyDropped() {
+		const string tempTestFile = "TestFiles/configurables/temp_trait_map_unmapped_logging.txt";
+		File.WriteAllText(tempTestFile,
+			"link = { ck3 = ck3Trait ir = mapped_trait }" +
+			"link = { ir = dropped_trait }"
+		);
+		var ck3ModFS = new ModFilesystem("TestFiles/CK3/game", new List<Mod>());
+		var mapper = new TraitMapper(tempTestFile, ck3ModFS);
+
+		var irModFS = new ModFilesystem("TestFiles/Imperator/game", new List<Mod>());
+		using var output = new StringWriter();
+		Console.SetOut(output);
+
+		mapper.LogUnmappedImperatorTraits(irModFS);
+
+		var outputString = output.ToString();
+		Assert.Contains($"No mapping for I:R traits found in trait mappings: unmapped_trait{Environment.NewLine}", outputString);
+	}
 }

ImperatorToCK3.UnitTests/TestFiles/Imperator/game/common/traits/test_traits.txt

@@ -0,0 +1,3 @@
+mapped_trait = { }
+dropped_trait = { }
+unmapped_trait = { }

ImperatorToCK3/CK3/World.cs

@@ -198,7 +198,10 @@ public World(Imperator.World impWorld, Configuration config, Thread? irCoaExtrac
 
 			() => cultureMapper = new CultureMapper(imperatorRegionMapper, ck3RegionMapper, Cultures),
 
-			() => traitMapper = new("configurables/trait_map.txt", ModFS),
+			() => {
+				traitMapper = new("configurables/trait_map.txt", ModFS);
+				traitMapper.LogUnmappedImperatorTraits(impWorld.ModFS);
+			},
 
 			() => {
 				Logger.Info("Initializing DNA factory...");