From ed1d053396dde07cfb58302c595c8d83872edf3c Mon Sep 17 00:00:00 2001 From: matiasperrone-exo Date: Wed, 25 Feb 2026 19:47:15 +0000 Subject: [PATCH 1/2] chore: Remove renamed trait methods --- .../OAuth2SummitBadgeTypeApiController.php | 31 +++--------------- .../OAuth2SummitDocumentsApiController.php | 21 ++---------- ...ummitSubmissionInvitationApiController.php | 32 +++---------------- 3 files changed, 11 insertions(+), 73 deletions(-) diff --git a/app/Http/Controllers/Apis/Protected/Summit/OAuth2SummitBadgeTypeApiController.php b/app/Http/Controllers/Apis/Protected/Summit/OAuth2SummitBadgeTypeApiController.php index aeb4409e1..5ea53dc25 100644 --- a/app/Http/Controllers/Apis/Protected/Summit/OAuth2SummitBadgeTypeApiController.php +++ b/app/Http/Controllers/Apis/Protected/Summit/OAuth2SummitBadgeTypeApiController.php @@ -101,21 +101,13 @@ protected function getOrderRules():array{ getAllBySummit as protected traitGetAllBySummit; } - use GetSummitChildElementById { - get as protected traitGet; - } + use GetSummitChildElementById; - use AddSummitChildElement { - add as protected traitAdd; - } + use AddSummitChildElement; - use UpdateSummitChildElement { - update as protected traitUpdate; - } + use UpdateSummitChildElement; - use DeleteSummitChildElement { - delete as protected traitDelete; - } + use DeleteSummitChildElement; #[OA\Get( path: "/api/v1/summits/{id}/badge-types", @@ -202,9 +194,6 @@ protected function getOrderRules():array{ new OA\Response(response: Response::HTTP_INTERNAL_SERVER_ERROR, description: "Server Error") ] )] - public function getAllBySummit($summit_id) { - return $this->traitGetAllBySummit($summit_id); - } #[OA\Get( path: "/api/v1/summits/{id}/badge-types/{badge_type_id}", @@ -268,9 +257,6 @@ public function getAllBySummit($summit_id) { new OA\Response(response: Response::HTTP_INTERNAL_SERVER_ERROR, description: "Server Error") ] )] - public function get($summit_id, $badge_type_id) { - return $this->traitGet($summit_id, $badge_type_id); - } #[OA\Post( path: "/api/v1/summits/{id}/badge-types", @@ -316,9 +302,6 @@ public function get($summit_id, $badge_type_id) { new OA\Response(response: Response::HTTP_INTERNAL_SERVER_ERROR, description: "Server Error") ] )] - public function add($summit_id) { - return $this->traitAdd($summit_id); - } #[OA\Put( path: "/api/v1/summits/{id}/badge-types/{badge_type_id}", @@ -371,9 +354,6 @@ public function add($summit_id) { new OA\Response(response: Response::HTTP_INTERNAL_SERVER_ERROR, description: "Server Error") ] )] - public function update($summit_id, $badge_type_id) { - return $this->traitUpdate($summit_id, $badge_type_id); - } #[OA\Delete( path: "/api/v1/summits/{id}/badge-types/{badge_type_id}", @@ -416,9 +396,6 @@ public function update($summit_id, $badge_type_id) { new OA\Response(response: Response::HTTP_INTERNAL_SERVER_ERROR, description: "Server Error") ] )] - public function delete($summit_id, $badge_type_id) { - return $this->traitDelete($summit_id, $badge_type_id); - } /** * @param array $payload diff --git a/app/Http/Controllers/Apis/Protected/Summit/OAuth2SummitDocumentsApiController.php b/app/Http/Controllers/Apis/Protected/Summit/OAuth2SummitDocumentsApiController.php index f60f3aa55..7348d34c2 100644 --- a/app/Http/Controllers/Apis/Protected/Summit/OAuth2SummitDocumentsApiController.php +++ b/app/Http/Controllers/Apis/Protected/Summit/OAuth2SummitDocumentsApiController.php @@ -42,17 +42,11 @@ class OAuth2SummitDocumentsApiController extends OAuth2ProtectedController { // traits - use GetAllBySummit { - getAllBySummit as protected traitGetAllBySummit; - } + use GetAllBySummit; - use GetSummitChildElementById { - get as protected traitGet; - } + use GetSummitChildElementById; - use DeleteSummitChildElement { - delete as protected traitDelete; - } + use DeleteSummitChildElement; use RequestProcessor; @@ -163,9 +157,6 @@ public function __construct new OA\Response(response: Response::HTTP_INTERNAL_SERVER_ERROR, description: "Server Error") ] )] - public function getAllBySummit($summit_id) { - return $this->traitGetAllBySummit($summit_id); - } #[OA\Get( path: "/api/v1/summits/{id}/summit-documents/{document_id}", @@ -220,9 +211,6 @@ public function getAllBySummit($summit_id) { new OA\Response(response: Response::HTTP_INTERNAL_SERVER_ERROR, description: "Server Error") ] )] - public function get($summit_id, $document_id) { - return $this->traitGet($summit_id, $document_id); - } #[OA\Post( path: "/api/v1/summits/{id}/summit-documents", @@ -486,9 +474,6 @@ public function update(LaravelRequest $request, $summit_id, $document_id){ new OA\Response(response: Response::HTTP_INTERNAL_SERVER_ERROR, description: "Server Error") ] )] - public function delete($summit_id, $document_id) { - return $this->traitDelete($summit_id, $document_id); - } /** * @inheritDoc diff --git a/app/Http/Controllers/Apis/Protected/Summit/OAuth2SummitSubmissionInvitationApiController.php b/app/Http/Controllers/Apis/Protected/Summit/OAuth2SummitSubmissionInvitationApiController.php index 983495e7a..e5234f895 100644 --- a/app/Http/Controllers/Apis/Protected/Summit/OAuth2SummitSubmissionInvitationApiController.php +++ b/app/Http/Controllers/Apis/Protected/Summit/OAuth2SummitSubmissionInvitationApiController.php @@ -48,21 +48,13 @@ final class OAuth2SummitSubmissionInvitationApiController extends OAuth2Protecte use ParametrizedGetAll; - use GetSummitChildElementById { - get as protected traitGet; - } + use GetSummitChildElementById; - use DeleteSummitChildElement { - delete as protected traitDelete; - } + use DeleteSummitChildElement; - use AddSummitChildElement { - add as protected traitAdd; - } + use AddSummitChildElement; - use UpdateSummitChildElement { - update as protected traitUpdate; - } + use UpdateSummitChildElement; /** * @var ISummitRepository @@ -578,10 +570,6 @@ protected function updateChild(Summit $summit, int $child_id, array $payload): I new OA\Response(response: Response::HTTP_INTERNAL_SERVER_ERROR, description: "Server Error") ] )] - public function get($summit_id, $invitation_id) - { - return $this->traitGet($summit_id, $invitation_id); - } #[OA\Post( path: "/api/v1/summits/{id}/submission-invitations", @@ -632,10 +620,6 @@ public function get($summit_id, $invitation_id) new OA\Response(response: Response::HTTP_INTERNAL_SERVER_ERROR, description: "Server Error") ] )] - public function add($summit_id) - { - return $this->traitAdd($summit_id); - } #[OA\Put( path: "/api/v1/summits/{id}/submission-invitations/{invitation_id}", @@ -693,10 +677,6 @@ public function add($summit_id) new OA\Response(response: Response::HTTP_INTERNAL_SERVER_ERROR, description: "Server Error") ] )] - public function update($summit_id, $invitation_id) - { - return $this->traitUpdate($summit_id, $invitation_id); - } #[OA\Delete( path: "/api/v1/summits/{id}/submission-invitations/{invitation_id}", @@ -744,10 +724,6 @@ public function update($summit_id, $invitation_id) new OA\Response(response: Response::HTTP_INTERNAL_SERVER_ERROR, description: "Server Error") ] )] - public function delete($summit_id, $invitation_id) - { - return $this->traitDelete($summit_id, $invitation_id); - } #[OA\Delete( path: "/api/v1/summits/{id}/submission-invitations/all", From 18dce12ba79aaa81a753be1987b170d893e41da3 Mon Sep 17 00:00:00 2001 From: matiasperrone-exo Date: Thu, 26 Feb 2026 20:41:03 +0000 Subject: [PATCH 2/2] chore: Remove trait alias --- .../Protected/Summit/OAuth2SummitBadgeTypeApiController.php | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/app/Http/Controllers/Apis/Protected/Summit/OAuth2SummitBadgeTypeApiController.php b/app/Http/Controllers/Apis/Protected/Summit/OAuth2SummitBadgeTypeApiController.php index 5ea53dc25..5e5f97143 100644 --- a/app/Http/Controllers/Apis/Protected/Summit/OAuth2SummitBadgeTypeApiController.php +++ b/app/Http/Controllers/Apis/Protected/Summit/OAuth2SummitBadgeTypeApiController.php @@ -97,9 +97,7 @@ protected function getOrderRules():array{ ]; } - use GetAllBySummit { - getAllBySummit as protected traitGetAllBySummit; - } + use GetAllBySummit; use GetSummitChildElementById;