-
Notifications
You must be signed in to change notification settings - Fork 208
Open
Labels
samplesIssues that are directly related to samples.Issues that are directly related to samples.
Description
Execution Plan: Resolving PRs 1477 and 1475
Background
- PRs: 1477 (Postgres) and 1475 (MySQL)
- Goal: Update the
app.yamlfiles for the GAE Flex Rails 7 tutorials to use modern Ruby versions (e.g., 3.2 or 3.3) onubuntu22, fixing the "end of support" error described in Issue Rails7 deployment to GAE Flex fails: Your runtime version for ruby is past End of Support. #1476. - Current Proposed Fix in PRs: Added
runtime_config: operating_system: "ubuntu22"toapp.yaml.
Current Roadblocks / Comments
- CI Pipeline Failures:
glasntidentified that the oldest tested Ruby version is failing due to issues with built-in Gemfile config versions. They suggested updating the repository's oldest supported testing ruby version. - Deployment Errors:
bipashanttested the PR and still received an error:runtime ruby32 is not selectable with operating system ubuntu22. This suggests the current patch in the PR is incomplete or incorrectly specifies the GAE Flex environment for newer Rubies.
Recommended Execution Steps
Step 1: Fix CI Matrix (Address glasnt's feedback)
- Investigate the central CI configurations (likely in
.kokoro/or.github/workflows/). - Update the Ruby version matrix to drop unsupported EOL Rubies (like 2.6/2.7/3.0) and include modern versions (3.2 and 3.3).
- Update the oldest tested Ruby to at least 3.1 or 3.2.
Step 2: Validate GAE Flex Configuration (Address bipashant's feedback)
- Research the exact
app.yamlsyntax required to run Ruby 3.2+ onubuntu22in GAE Flex. - It likely requires either:
- Adding a
.ruby-versionfile to the directories specifying3.2.3(or similar) AND keeping theoperating_system: "ubuntu22"inapp.yaml. - Specifying
runtime_versionunderruntime_configwithinapp.yaml.
- Adding a
- Deploy locally using
gcloud app deploy(or dry-run) to a test project to ensure theINVALID_ARGUMENTerror resolves.
Step 3: Implement Changes in PRs
- For both
appengine/rails-cloudsql-postgresandappengine/rails-cloudsql-mysql:- Adjust
app.yamlbased on the successful syntax from Step 2. - Adding
.ruby-versionif necessary. - Update
Gemfile/Gemfile.lockto reflect changes if bounded by bundler requirements.
- Adjust
- Commit these changes directly to the respective branches for PR 1477 (
palladius-patch-2) and PR 1475 (palladius-patch-1), or create a new consolidated PR linking both.
Step 4: Finalize
- Confirm CI passes after adjusting the ruby matrix.
- Reply to reviewers
glasntandbipashant, requesting re-review. - Merge the PRs.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
samplesIssues that are directly related to samples.Issues that are directly related to samples.