Skip to content

hardening: audit shell_exec and exec paths for command injection #249

@somethingwithproof

Description

@somethingwithproof

Findings (validated by xAI Grok security review)

shell_exec/exec with dynamic inputs (HIGH)

  • flowview_devices.php:893,897,901: shell_exec with $safe_port in netstat/ss commands
  • flowview_bulkarin.php:127: exec with whois queries (partially escaped)
  • functions.php:5820: exec with wget command
  • functions.php:6558: shell_exec with flow_export binary

Most paths use escapeshellarg() but some concatenate variables into shell pipeline strings.

Recommended fixes

Audit each exec path for complete escaping. Replace shell pipelines with direct PHP operations where possible.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions